threshold medium doesn't suppress shellcheck errors | Check

threshold medium doesn't suppress shellcheck errors

Ross

trunk.yaml

has:

lint:
  threshold:
    - linters: [shellcheck]
      level: medium

But if I have only low threshold shellcheck issues,

trunk check

still exits with status code 1 - so the github action fails.

Is there some other config required to enable the threshold to work?

Chris Clearwater

Thanks for reporting this, we will fix this bug in the next release.

Ross

Chris Clearwater: Any updates on this issue? This is still broken in 1.4.1 - trunk in github actions does not seem to respect

.trunk/config/.shellcheckrc

. But it works fine locally.

Ross

hmm - I can't reproduce this locally, it's only happening in github actions. And if I add e.g.

disable=SC2162

.trunk/config/.shellcheckrc

it works locally, but not in github actions.